add asdf upper pin until 3.0 issues can be resolved #1005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #997 (see: #997 (comment)) there are multiple issues with the crds test suite and asdf 3.0. Additionally asdf 3.0.0 has a bug in the asdftool diff output which appears to be used by crds.
This PR adds an upper pin to asdf 3.0 until these issues can be resolved.
Alternatively, #1004 addresses the asdf 3.0 incompatibilites. It is currently blocked by asdf-format/asdf#1672 and a release of asdf 3.0.1. If other crds changes are needed adding this pin is a faster option to allow the CI to pass. However it may create issues for jwst and romancal as it would prevent them from installing asdf 3.0.