TST: Turn Sphinx warning into error

[pllim]

I'm baaaack!

http://www.sphinx-doc.org/en/master/setuptools.html

[pllim]

@jhunkeler , I don't get it. There is 1 warning but test passed anyway. It is like Jenkins is ignoring setting in setup.cfg.

build succeeded, 1 warnings.

[mcara]

@pllim @stsci-hack @jhunkeler If you make changes that are worth communicating to the users, please DO NOT FORGET TO UPDATE the CHANGELOG

By the way, is it possible to block PRs unless there is an entry added to the changelog???

[pllim]

Usually, changes to doc and test do not need change log.

is it possible to block PRs unless there is an entry added to the changelog?

Yes, Astropy uses a bot to check changelog. If unsatisfactory, bot will request changes. And you can probably set your repo to disable commit until bot approves. @drdavella cloned that bot into stsci-bot a while ago but I have not seen it in action.

[mcara]

OK, then let's not get overboard, but just do not forget about CHANGELOG

[drdavella]

I'm late to this discussion, but currently that bot only runs on https://github.com/spacetelescope/asdf (see, for example, asdf-format/asdf#510 (comment)). If you want it to be enabled for other repositories, I can help with that.

[pllim]

It is Mihai and Warren's call...

[mcara]

I discussed the issue with @drdavella offline and it seems that we can ignore the bot when necessary (or if it misbehaves) and this addresses all my concerns. Considering the benefit of being reminded to add a changelog entry, I am all for having this bot.

[pllim]

Make it so, @drdavella ! :)

[drdavella]

This is actually something that needs to be done by someone with admin rights on the repo, but I can provide guidance (once I remind myself how I did it in the first place).

[pllim]

Someone removed my power on this repo. Can't help there. Sorry, Dan!

[mcara]

Someone removed my power on this repo.

However, I am sure @jhunkeler would be happy to help.