Modify wscript as OS no longer returns patch version #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… -productVersion.
pllim
reviewed
Sep 16, 2022
| # Convert major/minor/patch values into a single 24-bit integer | ||
| osx_version = (osx_version_major & 0xff) << 16 | (osx_version_minor & 0xff) << 8 | (osx_version_patch & 0xff ) | ||
| # Convert major/minor values into a single 24-bit integer | ||
| osx_version = (osx_version_major & 0xff) << 16 | (osx_version_minor & 0xff) << 8 |
There was a problem hiding this comment.
Huh... Maybe @jhunkeler might still be interested to look at this.
After all, he did try to be rid of waf and go back to cmake a couple of times (#412).
There was a problem hiding this comment.
No doubt. Brendan needs these changes ASAP so I did the expedient change.
|
Solution superseded by improved solution in #571. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS Monterey no longer returns a patch version for
/usr/bin/sw_vers -productVersion. Solution was to remove the obsolete code.