Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLA-1136: Flag full-well saturated pixels in the overscan regions in DQICORR #597

Merged
merged 3 commits into from
Oct 24, 2023
Merged

HLA-1136: Flag full-well saturated pixels in the overscan regions in DQICORR #597

merged 3 commits into from
Oct 24, 2023

Conversation

mdlpstsci
Copy link
Contributor

The WFC3 team realized the new way of flagging full-well saturated data using an image after the BLEVCORR/BIASCORR steps and the old way of flagging the data in DQICORR needed to be reconciled to account properly for any pixels which should have been flagged in the overscan regions. The overscan regions are trimmed in BLEVCORR/BIASCORR. The changes incorporated by the PR address this issue.

  1. The ComputeLimits function has been pulled from being a part of the dofwsat.c file to be its own file, /lib/computelimits.c, so it is available to other files.
  2. wscript file has been updated to include the new computelimits.c file.
  3. The findover.c file was reformatted as it was too difficult to trace through the code and understand the flow. There were no actual code changes.
  4. A parameter (int overscan) has been added to the API of doDQi.
  • doccd.c/doccd.h changed to accommodate the doDQI change.
  • do2d.c changed to accommodate the doDQI change.

@mdlpstsci
Updates to reconcile the old and new algorithms for flagging full-wel…
3532a2b 
…l saturated pixels.

The new algorithm uses a saturation image which is applied after BLECORR/BIASCORR, and
the image is already trimmed of the overscan regions. The old algorithm used a single
scalar value applied to the ENTIRE readout (science data and overscan).  Added flagging
in DQICORR of the overscan regions when the saturation image of the new algorithm is to
be applied later in the processing.
@mdlpstsci mdlpstsci self-assigned this Oct 24, 2023
@mdlpstsci mdlpstsci requested a review from a team as a code owner October 24, 2023 18:43
raswaters
raswaters previously approved these changes Oct 24, 2023
View reviewed changes
@mdlpstsci mdlpstsci merged commit ca83450 into spacetelescope:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raswaters raswaters raswaters approved these changes

@stscirij stscirij Awaiting requested review from stscirij

Assignees

@mdlpstsci mdlpstsci

Labels
bug changes-data enhancement priority: high WFC3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdlpstsci @raswaters