Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Unit Conversion to Hz breaks Line Lists plugin #1034

Open
Tracked by #1972
pllim opened this issue Jan 13, 2022 · 0 comments
Open
Tracked by #1972

BUG: Unit Conversion to Hz breaks Line Lists plugin #1034

pllim opened this issue Jan 13, 2022 · 0 comments
Labels
bug Something isn't working cubeviz

Comments

@pllim
Copy link
Contributor

pllim commented Jan 13, 2022 •
edited
Loading

Workflow to reproduce the bug:

  1. Start Cubeviz example notebook and load the data.
  2. Load SDSS lines. Show all of them. Red lines will appear on spectrum.
  3. Go to Unit Conversion plugin and convert spectral axis to Hz.

Bug: Red lines disappear. I expect them to stay.

🐱
@pllim pllim added bug Something isn't working cubeviz labels Jan 13, 2022
@kecnry kecnry mentioned this issue Jan 14, 2022
Merged
9 tasks
kecnry added a commit to kecnry/jdaviz that referenced this issue Jan 14, 2022
@kecnry
fix spectral lines during spectral unit conversion
aa673ff 
* rest value is converted to new value, redshift held fixed, x-value updated to plot units
* fixes spacetelescope#1034
kecnry added a commit to kecnry/jdaviz that referenced this issue Jan 14, 2022
@kecnry
fix spectral lines during spectral unit conversion
6d35816 
* rest value is converted to new value, redshift held fixed, x-value updated to plot units
* (partly) fixes spacetelescope#1034 (still need to handle spectral equivalencies properly)
@pllim pllim mentioned this issue Jan 21, 2022
Merged
9 tasks
kecnry added a commit to kecnry/jdaviz that referenced this issue Jan 28, 2022
@kecnry
fix spectral lines during spectral unit conversion
5bf62db 
* rest value is converted to new value, redshift held fixed, x-value updated to plot units
* (partly) fixes spacetelescope#1034 (still need to handle spectral equivalencies properly)
kecnry added a commit to kecnry/jdaviz that referenced this issue Feb 2, 2022
@kecnry
fix spectral lines during spectral unit conversion
c5f4b91 
* rest value is converted to new value, redshift held fixed, x-value updated to plot units
* (partly) fixes spacetelescope#1034 (still need to handle spectral equivalencies properly)
@rosteen rosteen mentioned this issue Jan 23, 2023
Closed
@pllim pllim mentioned this issue Jan 23, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cubeviz
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

POC: Add concept notebook using glue unit conversion javerbukh/jdaviz
1 participant
@pllim