Cubeviz: gap between two regions of the same spectral subset padded with zeros

[Jdaviz-Triage-Bot]

Reporter: Camilla Pacifici

Cubeviz:

• change function to sum for the spectrum in the spectral viewer
• select a spectral subset with two regions using "add"
• the gap in between the two regions gets filled with zeros

---

DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

[astrofrog]

I think this should be fixed by glue-viz/glue#2298 - can someone confirm?

[pllim]

@camipacifici has confirmed that upstream fix solved this. Thanks!

[stscijgbot-jwql]

This issue is tracked on JIRA as JDAT-2339.

[stscijgbot-jwql]

Comment by Duy Nguyen on JIRA:

NOTICE: A corresponding GitHub issue was automatically created: #1255

[stscijgbot-jwql]

Comment by Ori Fox on JIRA:

Camilla Pacifici Can you try this again with the latest dev install? I had this problem 2 weeks ago, but now it seems gone. 

[stscijgbot-jwql]

Comment by Pey-Lian Lim on JIRA:

Turns out this does not show up in "maximum" but shows up in "sum". Disabling GL does not fix the problem.

I think the actual logic is at https://github.com/glue-viz/glue/blob/1c718378b5527e64d85cc6a6f9a0330652e5cf4b/glue/utils/array.py#L414

Does it go through here too? I cannot tell for sure without more digging. https://github.com/glue-viz/glue-astronomy/blob/99966962d971ad779c9ac51da7055222c406e49f/glue_astronomy/translators/regions.py#L113

[stscijgbot-jwql]

Comment by Camilla Pacifici on JIRA:

Thank you Pey-Lian for taking a look.
Yes, the problem is with "sum" and still there as recently as yesterday.

[stscijgbot-jwql]

Comment by Pey-Lian Lim on JIRA:

Yes, we all saw the bug live this morning at tag-up, thanks to Richard O'Steen and Ori Fox. But the fix is not immediately obvious, so this ticket will need to be properly prioritized and pointed and all that.

[stscijgbot-jwql]

Comment by Camilla Pacifici on JIRA:

(y)

[stscijgbot-jwql]

Comment by Pey-Lian Lim on JIRA:

Someone should check if glue-viz/glue#2298 has fixed this problem. It is already merged, so all you have to do is to install dev version of glue-core and go through this use case.

[stscijgbot-jwql]

Comment by Camilla Pacifici on JIRA:

Checked and seems fixed!

[stscijgbot-jwql]

Comment by Pey-Lian Lim on JIRA:

Great to hear. Thanks for checking!