Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset Edit Plugin: Edit compound Subset #1568

Closed
Jdaviz-Triage-Bot opened this issue Aug 12, 2022 · 2 comments · Fixed by #2182
Closed

Subset Edit Plugin: Edit compound Subset #1568

Jdaviz-Triage-Bot opened this issue Aug 12, 2022 · 2 comments · Fixed by #2182
Labels
feature Feature request plugin Label for plugins common to multiple configurations

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Aug 12, 2022

Reporter: pllim

This is a follow-up of #1427 . Do we want to allow user to edit sub-Subsets in a compound Subset?

Things to consider:

  • Just how useful is this feature for image viewers? For example, compound Subset is useless for things like aperture photometry. What is it really used for?
  • For spectrum viewer, how should we handle a use case where user edits sub-Subsets to the point where they overlap, should we make it a non-compound Subset or throw exception?
  • For spectrum viewer, how robust is this feature for all sorts of spectral axes and WCSes that we support? Will this even work for WCS-TAB use case if user somehow edit sub-Subset that it falls within the gaps?
  • Is a compound Subset only one-level deep? What if they can be N-level deep, how do we handle editing that in a sane way?

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen

@stscijgbot-jwql
Copy link

This issue is tracked on JIRA as JDAT-2676.

@stscijgbot-jwql
Copy link

Comment by Duy Nguyen on JIRA:

NOTICE: A corresponding GitHub issue was automatically created: #1568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants