Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar mode doesn't resize the jdaviz height when it's moved around #1926

Closed
eteq opened this issue Dec 15, 2022 · 1 comment · Fixed by #1788
Closed

Sidecar mode doesn't resize the jdaviz height when it's moved around #1926

eteq opened this issue Dec 15, 2022 · 1 comment · Fixed by #1788
Labels
bug Something isn't working UI/UX😍

Comments

@eteq
Copy link
Contributor

eteq commented Dec 15, 2022

If I open up a jdaviz (for the illustration below I used imviz but I see the same on other viz'es) instance from jupyterlab using .show('sidecar:...'), it pops up just fine in the expected place, but if I move the window around, it doesn't resize the height, so there ends up being a lot of wasted whitespace - see the screenshots below. I can work-around this for now by doing .show('sidecar:...', height=the_size_of_the_browser_window) but that's not idea if I re-arrange my jupyterlab workspace.

The screenshots below come from showing an imviz window as .show('sidcar:tab-after') and then dragging it first down below the notebook, and then off to the right. In both cases the width correctly updates but the height does not

Screenshot from 2022-12-15 17-06-08
Screenshot from 2022-12-15 17-06-49

@eteq
Copy link
Contributor Author

eteq commented Dec 15, 2022

This might be fixed by #1788 but I haven't gotten that PR to work to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI/UX😍
Projects
None yet
1 participant