MNT: Unpin maxversion of ipywidgets now that voila 0.4 is out, minversion ipywidgets now 8 #1788

pllim · 2022-10-27T17:17:54Z

Description

This pull request is to fix #1613 and fix #1787 and fix #1926 and fix #1938

Multiple devs should check that things are truly fixed by this new voila release since several things were broken before. Make sure your ipywidgets is at least v8 and voila is v0.4 when you test.

Blocked by

Hold sync during update from front-end is very un-ipywidgets like jupyter-widgets/ipywidgets#3635 that requires reverting Hold sync during set_state + fix selection widgets flakiness jupyter-widgets/ipywidgets#3271, see fix: do not hold sync during set_state jupyter-widgets/ipywidgets#3642
8.0 compatibility jupyter-widgets/jupyterlab-sidecar#86
Exclude bad ipykernel version #1937

Bugs check list

Spinner shows in Link Control when click on WCS.
Standalone app still works.
Viewer resizes display when popped out.
Display not empty when popped out?
Does sidecar work? Does content in sidecar resize correctly? (Sidecar mode doesn't resize the jdaviz height when it's moved around #1926)

Change log entry

Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
Do the proposed changes follow the STScI Style Guides?
Are tests added/updated as required? If so, do they follow the STScI Style Guides?
Are docs added/updated as required? If so, do they follow the STScI Style Guides?
Did the CI pass? If not, are the failures related?
Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

codecov · 2022-10-27T17:28:40Z

Codecov Report

Base: 91.79% // Head: 91.79% // No change to project coverage 👍

Coverage data is based on head (d861561) compared to base (04a744c).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1788   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         140      140           
  Lines       14951    14951           
=======================================
  Hits        13724    13724           
  Misses       1227     1227

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

pllim · 2022-10-28T14:14:32Z

This now conflicts with the proposed change for another bug in #1791

rosteen

I confirmed that the stand-alone version of the app works with this, and it also fixes the recent problem I was seeing with the popped-out application viewer heights. The latter is a bug in 3.1, so I would advocated for changing the milestone of this to 3.1.1.

rosteen · 2022-10-28T17:07:15Z

I can't quite tell if the test failure is a transient connection error downloading a file or an actual issue with dev Viola install. Maybe both? 😅

pllim · 2022-10-28T18:13:41Z

HTTP Error 503: Service Temporarily Unavailable -- I will restart.

pllim · 2022-10-28T19:38:14Z

CI is all green now.

kecnry

Standalone and popout windows seem to behave well for me. Not sure why one test isn't reporting its status though... but otherwise I say we get this in!

pllim · 2022-11-01T17:20:01Z

Ah, I updated the branch protection. Lemme rebase when I get a chance. Good catch!

pllim · 2022-11-01T17:38:15Z

Did @duytnguyendtn ever have a chance to test this on Windows? Or did you already try that? If not, I'll wait till I have time to do that before merge.

pllim · 2022-11-01T18:48:57Z

Timeout error is unrelated.

pllim · 2022-11-02T19:21:17Z

Unfortunately, I found #1598 (comment) to still be a problem, so I am turning this back into draft.

Stale

rosteen · 2022-12-16T19:50:00Z

Alright, I started from a fresh environment and installed from this PR. I confirmed that the sidecar height bug is fixed, but popout seems completely broken for me - I get a new window, but it's blank and never populates. Could someone else see if they see the same thing?

maartenbreddels · 2022-12-16T20:09:35Z

Something @mariobuikhuizen could look into?

On Fri, 16 Dec 2022 at 20:50, rosteen ***@***.***> wrote: Alright, I started from a fresh environment and installed from this PR. I confirmed that the sidecar height bug is fixed, but popout seems completely broken for me - I get a new window, but it's blank and never populates. Could someone else see if they see the same thing? — Reply to this email directly, view it on GitHub <#1788 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANPEPNYD4AMDO6QWSFKN3TWNTBXHANCNFSM6AAAAAARQI6ETM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Maarten Breddels Software engineer / consultant / data scientist Python / C++ / Javascript / Jupyter www.maartenbreddels.com / vaex.io ***@***.*** +31 6 2464 0838 <+31+6+24640838> [image: Twitter] <https://twitter.com/maartenbreddels>[image: Github] <https://github.com/maartenbreddels>[image: LinkedIn] <https://linkedin.com/in/maartenbreddels>[image: Skype]

javerbukh · 2022-12-16T20:36:50Z

I'm seeing the opposite @rosteen , sidecar height is not updating accurately but popout works just fine. Clean conda environment and ipywidgets version 8.0.3.

javerbukh · 2022-12-16T20:40:52Z

This is what I see when the sidecar tab is below the notebook view

rosteen · 2022-12-16T20:46:48Z

Interesting, I get a scrollbar on the sidecar tab so that I can see the rest of the GUI.

javerbukh · 2022-12-16T20:49:47Z

@rosteen Same, is that the expected behavior?

rosteen · 2022-12-16T20:51:05Z

I thought so, but maybe we need @eteq to confirm what the expected behavior is.

pllim · 2022-12-16T21:50:10Z

On my end (Imviz on Windows 10):

✔️Spinner shows in Link Control when click on WCS.
✔️Standalone app still works.
✔️Viewer resizes display when popped out.
✔️Does sidecar work? I used "sidecar:right"

pllim · 2022-12-16T21:52:53Z

I rebased this PR, just in case. 🤞

pllim · 2022-12-20T21:40:39Z

FYI. I added the bump of ipykernel here too. Please see if your problems are gone now. Thanks!

now that voila 0.4 is out. In fact, we pin minversion ipywidgets to its new release. Also bump pin for sidecar to they are all compatible.

that was pinned in spacetelescope#1937

rosteen

I just re-tested with sidecar and I don't see any difference between the behavior here and on main, so I think any changes to that behavior can be separate work if needed. I think we can merge this.

pllim · 2023-01-18T19:37:56Z

Okay, I'll squash-merge. We can always revert if someone finds some new problem after-the-fact. Let's not backport. Thanks!

pllim added the no-changelog-entry-needed changelog bot directive label Oct 27, 2022

pllim added this to the 3.2 milestone Oct 27, 2022

pllim requested review from duytnguyendtn, rosteen, javerbukh, ojustino, kecnry and bmorris3 as code owners October 27, 2022 17:17

pllim mentioned this pull request Oct 28, 2022

fix: plots in popout window not scaled properly (by pinning voila<0.4) #1791

Merged

9 tasks

pllim force-pushed the unpin-ipyw-maxver branch from 7723341 to 86f59a9 Compare October 28, 2022 15:11

pllim changed the title ~~MNT: Unpin maxversion of ipywidgets now that voila 0.4 is out~~ MNT: Unpin maxversion of ipywidgets now that voila 0.4 is out, minversion ipywidgets now 8 Oct 28, 2022

rosteen previously approved these changes Oct 28, 2022

View reviewed changes

pllim modified the milestones: 3.2, 3.1.1 Oct 28, 2022

pllim added 💤backport-v3.1.x on-merge: backport to v3.1.x bug Something isn't working embed Regarding issues with front-end embedding Ready for final review labels Oct 28, 2022

kecnry previously approved these changes Nov 1, 2022

View reviewed changes

pllim force-pushed the unpin-ipyw-maxver branch from 86f59a9 to 92b87a4 Compare November 1, 2022 17:39

pllim force-pushed the unpin-ipyw-maxver branch from 92b87a4 to 3d8792c Compare November 2, 2022 18:38

eteq mentioned this pull request Dec 15, 2022

Sidecar mode doesn't resize the jdaviz height when it's moved around #1926

Closed

pllim force-pushed the unpin-ipyw-maxver branch from e3f1b8f to e3e5c84 Compare December 16, 2022 21:51

rosteen mentioned this pull request Dec 20, 2022

Exclude bad ipykernel version #1937

Merged

pllim force-pushed the unpin-ipyw-maxver branch from e3e5c84 to 75f6702 Compare December 20, 2022 21:35

pllim modified the milestones: 3.1.2, 3.1.3 Dec 20, 2022

pllim added 3 commits December 28, 2022 11:07

MNT: Unpin maxversion of ipywidgets

410171c

now that voila 0.4 is out. In fact, we pin minversion ipywidgets to its new release. Also bump pin for sidecar to they are all compatible.

Ignore Widget deprecation warning

3750c96

Unpin ipykernel maxversion

d861561

that was pinned in spacetelescope#1937

pllim force-pushed the unpin-ipyw-maxver branch from 75f6702 to d861561 Compare December 28, 2022 16:07

rosteen modified the milestones: 3.1.3, 3.2.1 Jan 4, 2023

rosteen approved these changes Jan 18, 2023

View reviewed changes

pllim modified the milestones: 3.2.1, 3.3 Jan 18, 2023

pllim removed the 💤backport-v3.1.x on-merge: backport to v3.1.x label Jan 18, 2023

pllim merged commit 8faf482 into spacetelescope:main Jan 18, 2023

pllim deleted the unpin-ipyw-maxver branch January 18, 2023 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MNT: Unpin maxversion of ipywidgets now that voila 0.4 is out, minversion ipywidgets now 8 #1788

MNT: Unpin maxversion of ipywidgets now that voila 0.4 is out, minversion ipywidgets now 8 #1788

pllim commented Oct 27, 2022 •

edited

Loading

codecov bot commented Oct 27, 2022 •

edited

Loading

pllim commented Oct 28, 2022

rosteen left a comment

rosteen commented Oct 28, 2022 •

edited

Loading

pllim commented Oct 28, 2022

pllim commented Oct 28, 2022

kecnry left a comment

pllim commented Nov 1, 2022

pllim commented Nov 1, 2022

pllim commented Nov 1, 2022

pllim commented Nov 2, 2022

rosteen commented Dec 16, 2022

maartenbreddels commented Dec 16, 2022 via email

javerbukh commented Dec 16, 2022

javerbukh commented Dec 16, 2022

rosteen commented Dec 16, 2022

javerbukh commented Dec 16, 2022

rosteen commented Dec 16, 2022

pllim commented Dec 16, 2022

pllim commented Dec 16, 2022

pllim commented Dec 20, 2022

rosteen left a comment

pllim commented Jan 18, 2023 •

edited

Loading

MNT: Unpin maxversion of ipywidgets now that voila 0.4 is out, minversion ipywidgets now 8 #1788

MNT: Unpin maxversion of ipywidgets now that voila 0.4 is out, minversion ipywidgets now 8 #1788

Conversation

pllim commented Oct 27, 2022 • edited Loading

Description

Blocked by

Bugs check list

Change log entry

Checklist for package maintainer(s)

codecov bot commented Oct 27, 2022 • edited Loading

Codecov Report

pllim commented Oct 28, 2022

rosteen left a comment

Choose a reason for hiding this comment

rosteen commented Oct 28, 2022 • edited Loading

pllim commented Oct 28, 2022

pllim commented Oct 28, 2022

kecnry left a comment

Choose a reason for hiding this comment

pllim commented Nov 1, 2022

pllim commented Nov 1, 2022

pllim commented Nov 1, 2022

pllim commented Nov 2, 2022

rosteen commented Dec 16, 2022

maartenbreddels commented Dec 16, 2022 via email

javerbukh commented Dec 16, 2022

javerbukh commented Dec 16, 2022

rosteen commented Dec 16, 2022

javerbukh commented Dec 16, 2022

rosteen commented Dec 16, 2022

pllim commented Dec 16, 2022

pllim commented Dec 16, 2022

pllim commented Dec 20, 2022

rosteen left a comment

Choose a reason for hiding this comment

pllim commented Jan 18, 2023 • edited Loading

pllim commented Oct 27, 2022 •

edited

Loading

codecov bot commented Oct 27, 2022 •

edited

Loading

rosteen commented Oct 28, 2022 •

edited

Loading

pllim commented Jan 18, 2023 •

edited

Loading