Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 compatibility #86

Merged
merged 8 commits into from
Dec 10, 2022
Merged

8.0 compatibility #86

merged 8 commits into from
Dec 10, 2022

Conversation

jasongrout
Copy link
Member

@jasongrout jasongrout commented Apr 16, 2022

This PR aims to have the codebase compatible with ipywidgets 7 and ipywidgets 8.

This also drops support for python 3.6, which has reached EOL.

We have to force it since prerelease packages don't take precedence over current packages.
@jasongrout
Copy link
Member Author

c154430 should be deleted after ipywidgets 8 is released - it's only there to force npm to choose the prerelease versions so we can test ipywidgets 8.

These changes were generated by comparing with the latest cookiecutter
@mwcraig
Copy link
Contributor

mwcraig commented Oct 23, 2022

@jasongrout - This works for me locally now. Adding the dependency on css-loader fixed the odd error I showed you on Friday.

I have not fixed this use of ManagerBase in the sidecar tests. When I tried to change it following the migration guide I got an error that Type 'ManagerBase' is not generic.

@martinRenou
Copy link
Member

When I tried to change it following the migration guide I got an error that Type 'ManagerBase' is not generic

This can be fixed by removing the <HTMLElement> part: ManagerBase<HTMLElement> -> ManagerBase

@mwcraig
Copy link
Contributor

mwcraig commented Oct 24, 2022

This can be fixed by removing the part: ManagerBase -> ManagerBase

Thanks, done. One of these days I should really try to learn typescript...

@mwcraig
Copy link
Contributor

mwcraig commented Oct 24, 2022

No idea why the extension isn't being installed...there was a compilation issue caused by openssl3 dropping support for md4 hashes, see https://stackoverflow.com/questions/69719601/getting-error-digital-envelope-routines-reason-unsupported-code-err-oss

@eteq
Copy link

eteq commented Dec 8, 2022

Poking about the status of this one. Any sense whether this is a deep problem vs "just need to convince the CI to reognize the right version"?

@jasongrout jasongrout marked this pull request as ready for review December 10, 2022 12:32
@jasongrout jasongrout merged commit d592c03 into jupyter-widgets:master Dec 10, 2022
@jasongrout
Copy link
Member Author

I manually checked also that I could build the python package and install it with ipywidgets 7 and ipywidgets 8 and it worked correctly for the readme example.

@jasongrout
Copy link
Member Author

We just released 0.5.2, which enables ipywidgets 8 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants