Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDAT-1484: Imviz region support: Plugin to rotate and center shapes #634

Closed
pllim opened this issue May 21, 2021 · 1 comment · Fixed by #1587
Closed

JDAT-1484: Imviz region support: Plugin to rotate and center shapes #634

pllim opened this issue May 21, 2021 · 1 comment · Fixed by #1587

Comments

@pllim
Copy link
Contributor

pllim commented May 21, 2021

@eteq -- After some out-of-band discussion, I think we've settled on the idea that the initial implementation should be:

  • A panel that handles rotation angle and pixel-level centering. That makes the workload for the rectangle easier since no UI changes are needed. We can consider a fancy rotation thingie later if it seems like it's useful, but not in this issue.
  • That panel can later also do things like altering the region properties, etc. It should probably be a jdaviz plugin to start with, but it might/should be baked into glupyter at some point, and we can decide then whether we want to keep it as a "plugin" or not.

More discussions in #518. Also see glue-viz/glue-jupyter#224.

Blocked by:

🐱

@pllim pllim added the imviz label May 21, 2021
@pllim pllim added this to the Imviz 1.0 milestone May 21, 2021
@pllim pllim mentioned this issue Jul 14, 2021
3 tasks
@pllim pllim removed this from the Imviz 1.0 milestone Sep 14, 2021
@pllim
Copy link
Contributor Author

pllim commented Jun 28, 2022

Rotation should be possible when glue-core v1.5.0 is released.

Screenshot 2022-06-28 162933

from glue.core.roi import RectangularROI

imviz.default_viewer.apply_roi(RectangularROI(1395, 1627, 1176, 1273, 45))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant