Imviz: Subset control plugin #729
Conversation
pllim
force-pushed
the
you-spin-me-right-round-right-round
branch
from
7434300 to
3d387f3
Compare
| # TODO: Using echo.delay_callback breaks the call too. | ||
| cur_roi = self._all_subsets[self._selected_subset_label] | ||
| try: | ||
| cur_roi.move_to(self.new_subset_x, self.new_subset_y) |
There was a problem hiding this comment.
@astrofrog , this does not give me any Exception but it also does not move the Subset. I cannot tell if I am doing this wrong or this is part of your upcoming upstream fix along with the angle support.
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
==========================================
- Coverage 62.83% 62.62% -0.21%
==========================================
Files 65 67 +2
Lines 4286 4348 +62
==========================================
+ Hits 2693 2723 +30
- Misses 1593 1625 +32
Continue to review full report at Codecov.
|
|
PO agreed that this is no longer MVP. |
|
p.s. I fantasized about maybe at least get this in only for ellipse for 2.0 but it appears to not be possible anyway because glue-astronomy translator does not take the angle and glue core does not support rotated ellipse. I thought it did. Ah, well. |
|
A user asked for a similar capability in Cubeviz during Jwebbinar 8. Paraphrased: " I want to specify the centers of the circular subsets by entering their exact values rather than using the cursor". The Subset editor should also have the capability to create a new subset as well as edit an existing one. |
|
I think discussions has gone beyond this to something else. |
New plugin to control Subset angle and position. Fix #634
TODOnotes in the code.Note: There is a noticeable lag when the "Subset" drop-down list is first populated when images are linked. I think it is related to #723 and is out of scope here.