Correct the linking for 1D model results in Cubeviz #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
requested review from
duytnguyendtn,
javerbukh,
ojustino,
pllim and
kecnry
as code owners
rosteen
added
no-changelog-entry-needed
|
I'm marking this no-changelog-needed since the bug was never released. |
kecnry
approved these changes
Jul 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #1531 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 91 91
Lines 8660 8660
=======================================
Hits 7391 7391
Misses 1269 1269
Continue to review full report at Codecov.
|
|
regarding changelog - should we put this PR number in the original changelog entry where it was introduced since it basically modifies that PR? |
|
Good idea, I'll do that. |
rosteen
force-pushed
the
fix-cubeviz-model-fitting
branch
from
2843d2c to
dd18ce4
Compare
…i-D ref data Update changelog
rosteen
force-pushed
the
fix-cubeviz-model-fitting
branch
from
dd18ce4 to
4d5142d
Compare
javerbukh
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been grabbing the last world coordinate, not the first, in case the reference data is multi-dimensional.
Closes #1530