-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Shift+b to blink backwards #1558
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1558 +/- ##
=======================================
Coverage 85.44% 85.45%
=======================================
Files 94 94
Lines 9058 9061 +3
=======================================
+ Hits 7740 7743 +3
Misses 1318 1318
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having the tool in the toolbar is convenient, and that adding reversed functionality does not quite warrant the "overhead" of a full plugin (yet). Maybe just adding a note of the shift+B to the existing tool's tooltip would help make this a bit more discoverable? It might also be possible to have a right-click with the tool active to trigger reversed blink?
Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
a6980b5
to
e1ed64c
Compare
I added a commit that implements support for right-click. Note that tool is still activated with a left click, but then right-clicking on the viewer blinks in the reversed direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works like a charm for me with both B and the right click!
Harry's approval counts as second approval? 😸 |
Description
This pull request is to add the ability to press Shift + b to blink backwards.
Fixes #1424
TODO
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?