-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set bounding box to None to avoid layer cropping #1908
Conversation
9bd5e14
to
aae0bd7
Compare
aae0bd7
to
2f60965
Compare
as bounding_box will be cleared in spacetelescope#1908
as bounding_box will be cleared in spacetelescope#1908
as bounding_box will be cleared in spacetelescope#1908
@pllim just to remind you: astropy/astropy#9073 Also, see the related/linked issue in |
2f60965
to
40e2f92
Compare
Codecov ReportBase: 91.72% // Head: 91.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1908 +/- ##
==========================================
+ Coverage 91.72% 91.79% +0.07%
==========================================
Files 140 140
Lines 14824 14951 +127
==========================================
+ Hits 13597 13724 +127
Misses 1227 1227
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
40e2f92
to
c10cfb7
Compare
@pllim @rosteen - this is what I came up with for the mouseover display, let me know what you think. The text changes to a gray and shows "(est.)" below the "World" entry to indicate the coordinates are less reliable since they are outside the original bounding box. Note here the "E"/red image is the top-layer showing flux values, whereas the "A"/gray image is the reference data, so Screen.Recording.2022-12-13.at.4.11.25.PM.mov |
6c2927a
to
4f46f3a
Compare
4f46f3a
to
9c93877
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise LGTM but I have suggestions on clarifying this new feature in the doc. Overall, the solution is very clean. Thanks!
* outside reference data's bounding box makes both pixel and sky coordinates "estimated" * outside active layer's bounding box makes the pixel coordinates "estimated"
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
f00924c
to
3fc771c
Compare
3fc771c
to
9e85b73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to step away for lunch break. Just posting this now so I don't lose it if I lose power. I am still looking at this. If you wanna apply now, feel free.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was pretty thorough with this and I am happy on its current state. Though I am also a co-author now, so take my approval however you want. 😬
Thanks for tackling this, Kyle!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work in my testing, and the test coverage looks good. I left one question about a class name but it's not a blocker/crucial to merge.
This comment was marked as resolved.
This comment was marked as resolved.
* set bounding box to None to avoid layer cropping * mouseover display to warn when outside original bounding box Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
…yer cropping * set bounding box to None to avoid layer cropping * mouseover display to warn when outside original bounding box Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
…yer cropping * set bounding box to None to avoid layer cropping * mouseover display to warn when outside original bounding box Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
This is a quick follow-up of spacetelescope#1908
Description
This pull request fixes WCS without fast-approximation resulting in layer cropping for images with GWCS by disabling the bounding box. This also allows the mouseover coordinates to extrapolate across the entire viewer based on the G/WCS of the reference image.
Fixes #1905, fixes #1899, fixes #1509
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.