Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1937 on branch v3.1.x (Exclude bad ipykernel version) #1939

Conversation

meeseeksmachine
Copy link

Backport PR #1937: Exclude bad ipykernel version

@lumberbot-app lumberbot-app bot added this to the 3.1.2 milestone Dec 20, 2022
@lumberbot-app lumberbot-app bot added 💤backport-v3.1.x on-merge: backport to v3.1.x bug Something isn't working no-changelog-entry-needed changelog bot directive labels Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 87.90% // Head: 91.23% // Increases project coverage by +3.33% 🎉

Coverage data is based on head (73dbc52) compared to base (6dbe259).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3.1.x    #1939      +/-   ##
==========================================
+ Coverage   87.90%   91.23%   +3.33%     
==========================================
  Files          95      139      +44     
  Lines       10228    14210    +3982     
==========================================
+ Hits         8991    12965    +3974     
- Misses       1237     1245       +8     
Impacted Files Coverage Δ
jdaviz/configs/imviz/tests/test_links_control.py 100.00% <0.00%> (ø)
...efault/plugins/model_fitting/tests/test_fitting.py 99.14% <0.00%> (ø)
jdaviz/configs/specviz/tests/test_helper.py 100.00% <0.00%> (ø)
...gins/metadata_viewer/tests/test_metadata_viewer.py 100.00% <0.00%> (ø)
...iz/plugins/slit_overlay/tests/test_slit_overlay.py 76.92% <0.00%> (ø)
...onfigs/imviz/plugins/compass/tests/test_compass.py 100.00% <0.00%> (ø)
...nfigs/cubeviz/plugins/tests/test_cubeviz_helper.py 100.00% <0.00%> (ø)
...igs/mosviz/tests/test_source_identifier_extract.py 100.00% <0.00%> (ø)
...gins/unit_conversion/tests/test_unit_conversion.py 100.00% <0.00%> (ø)
...default/plugins/model_fitting/tests/test_plugin.py 100.00% <0.00%> (ø)
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rosteen rosteen merged commit 20e330b into spacetelescope:v3.1.x Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive 💤backport-v3.1.x on-merge: backport to v3.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants