-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpin max glue #2196
unpin max glue #2196
Conversation
* to forbid broken 1.10, but allow versions after
Ah, so it is upstream bug? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2196 +/- ##
==========================================
- Coverage 91.78% 91.68% -0.11%
==========================================
Files 147 147
Lines 16262 16269 +7
==========================================
- Hits 14926 14916 -10
- Misses 1336 1353 +17
☔ View full report in Codecov by Sentry. |
Note that this also skips two tests that use remote data that are now failing to fetch the URLs so that tests could run. Do we want to split that out or remove it from here? EDIT: created #2197 to follow-up and revive the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Green CI is good CI.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Description
This pull request removes the max-pin on glue but forbids the broken 1.10 version.
Fixes #2183
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.