Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Grab dev spectral-cube and radio-beam to fix devdeps #2511

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 12, 2023

Description

We still cannot escape having to install spectral-cube because of glue-viz/glue-astronomy#62 . So we need:

to be released upstream.

Example failure: https://github.com/spacetelescope/jdaviz/actions/runs/6500257549/job/17655283046

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim added Upstream fix required testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤 backport-v3.7.x on-merge: backport to v3.7.x labels Oct 12, 2023
@pllim pllim added this to the 3.7.1 milestone Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@pllim
Copy link
Contributor Author

pllim commented Oct 12, 2023

radio_beam/_astropy_init.py

@pllim
Copy link
Contributor Author

pllim commented Oct 12, 2023

Well that is annoying. I cannot make spectral-cube disappear either. So the only thing left to do is to also wait for radio-beam to get patched. 😿

even though we do not use them because glue-astronomy
insists on pulling in spectral-cube and spectral-cube pulls in radio-beam.
@pllim pllim changed the title TST: Grab dev spectral-cube to fix devdeps TST: Grab dev spectral-cube and radio-beam to fix devdeps Oct 13, 2023
@pllim pllim marked this pull request as ready for review October 13, 2023 14:09
@pllim pllim merged commit bf48f7b into spacetelescope:main Oct 13, 2023
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Oct 13, 2023
@pllim pllim deleted the no-escape branch October 13, 2023 14:36
pllim added a commit that referenced this pull request Oct 13, 2023
…1-on-v3.7.x

Backport PR #2511 on branch v3.7.x (TST: Grab dev spectral-cube and radio-beam to fix devdeps)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two Upstream fix required 💤 backport-v3.7.x on-merge: backport to v3.7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant