Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix Cubeviz parsing DN and DN/s #3298

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 15, 2024

Description

This pull request is to fix parsing of cube in DN and DN/s units in Cubeviz. This is a follow-up of #3221 that is not yet released, so no need for change log.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added bug Something isn't working no-changelog-entry-needed changelog bot directive labels Nov 15, 2024
@pllim pllim added this to the 4.1 milestone Nov 15, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Nov 15, 2024
@pllim pllim added the trivial Only needs one approval instead of two label Nov 15, 2024
@pllim
Copy link
Contributor Author

pllim commented Nov 15, 2024

Tsk tsk OSX queue up my job for no reason. Maybe someone in spacetelescope used up the quota for the day or something.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (5d04203) to head (3060a42).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3298   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         125      125           
  Lines       19011    19011           
=======================================
  Hits        16883    16883           
  Misses       2128     2128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@camipacifici camipacifici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! Thank you!

@pllim pllim merged commit 1408806 into spacetelescope:main Nov 15, 2024
33 checks passed
@pllim pllim deleted the dn-s-pix2 branch November 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants