-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding links to ramp fitting docs for roman and jwst in rampviz #3301
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
==========================================
+ Coverage 88.78% 88.81% +0.02%
==========================================
Files 125 125
Lines 18832 19036 +204
==========================================
+ Hits 16720 16906 +186
- Misses 2112 2130 +18 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jdaviz/components/external_link.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kecnry – is this ok for you? This removes the line break after the div
, but also removes the top margin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does it look everywhere else that we use it? If those look ok, then great, otherwise we might want a toggle (can also have dynamic styling on the div to force in the same line).
|
||
Data products from infrared detectors flow through the official | ||
`JWST <https://jwst-pipeline.readthedocs.io/en/latest/>`_ or | ||
`Roman <https://roman-pipeline.readthedocs.io/en/latest/>`_ mission pipelines in levels. Infrared detectors use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this should also be using :ref:
but I cannot find a good place to do it where it exist already. Might need to add one upstream or maybe use :doc:
as you have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for now. Thx.
…r roman and jwst in rampviz
…1-on-v4.0.x Backport PR #3301 on branch v4.0.x (Adding links to ramp fitting docs for roman and jwst in rampviz)
Description
Rampviz does a quick-look ramp extraction which does not make data quality classifications, or fit ramps, or correct for detector effects/defects. This PR adds notes on these caveats to the Ramp Extraction plugin and the Ramp Extraction section of the docs.
Here's a preview of the new docs section:
Here's a preview of the new text and links in the plugin:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.