Respect loaded mask cube properly in spectral extraction. #3319
Conversation
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
github-actions
bot
added
specviz
plugin
rosteen
force-pushed
the
extract-cube-masks-fix
branch
2 times, most recently
from
209915f
to
bab8070
Compare
rosteen
force-pushed
the
extract-cube-masks-fix
branch
from
bab8070
to
6ee7daf
Compare
| @@ -22,6 +22,7 @@ class Cubeviz(CubeConfigHelper, LineListMixin): | |||
|
|
|||
| _loaded_flux_cube = None | |||
| _loaded_uncert_cube = None | |||
| _loaded_mask_cube = None | |||
There was a problem hiding this comment.
Maybe give @javerbukh co-author credit given #2718 ?
There was a problem hiding this comment.
The code itself looks good to me - just a few workflow related questions to consider:
Do we want (now or as a a follow-up ticket) to have a dropdown to select the mask cube? Should the default be to apply the mask or to not apply it?
What happens if the intersection between an aperture and the mask results in no pixels?
Should the mask be used in other plugins as well (aperture photometry, moment map, collapse, etc)?
|
I think that if it is used, it should be used everywhere (it can be a follow up issue). Can there maybe be an option at load_data to load AND use the mask? I would not set it to use by default, but maybe there could be a warning at loading like "there is a mask extension, if you want to load it do blah" |
|
Visualize the mask cube would be very useful! |
Fixes #3312.
Close #2718