Add elliptical ROI button to imviz

[javerbukh]

Requires glue-viz/glue-jupyter#241
Elliptical ROI functionality added in glue-jupyter v0.7

Resolves #635

Screenshot is slightly outdated, a better icon for elliptical ROI is being used.

[ibusko]

The button creates a circular region; I couldn't figure out how to make it elliptical.

[codecov]

Codecov Report

Merging #706 (3b27caf) into main (9ce4a91) will increase coverage by 0.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
+ Coverage   61.05%   61.70%   +0.64%     
==========================================
  Files          65       65              
  Lines        4157     4222      +65     
==========================================
+ Hits         2538     2605      +67     
+ Misses       1619     1617       -2     

Impacted Files	Coverage Δ
jdaviz/configs/imviz/plugins/viewers.py	40.00% <ø> (-0.75%)	⬇️
jdaviz/configs/imviz/helper.py	98.71% <0.00%> (+3.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce4a91...3b27caf. Read the comment docs.

[ibusko]

Works as expected.

[pllim]

As discovered by @rosteen , "get region" for this new shape does not work without glue-viz/glue-astronomy#32 . If this is merged before glue-astronomy with that patch can be released, we need to open a new issue as follow up.

[pllim]

I see the same "lag in moving it" and "get region breakage" that @rosteen reported.

I will withhold approval until we know whether to wait for new glue-astronomy release or not.

Nice work otherwise!

[rosteen]

Not sure if this possibility was mentioned offline, but now that the required glue-astronomy PR was merged we could change that requirement pin to the dev version and create a follow-up issue here to update the pin to the newest version once an actual glue-astronomy release happens.

[pllim]

pin to the dev version

There was a precedent... I think that is acceptable.

[pllim]

Confirmed that "get region" is fixed with glue-astronomy dev version:

>>> regions = imviz.app.get_subsets_from_viewer('viewer-1')
>>> regions
{'Subset 1': <EllipsePixelRegion(PixCoord(x=1539.462646484375, y=1322.1376953125), width=626.53564453125, height=88.5322265625, angle=0.0 deg)>}

The lag still there.

[rosteen]

@javerbukh If you update the glue-astronomy dependence to the dev version I'll approve and merge this, and create a follow-up issue to update the dependence after the next glue-astronomy release.

[javerbukh]

@rosteen Done, thank you!

[pllim]

FWIW, I opened #711 and #712 as follow up issues. I'll leave the merge for @rosteen . Thanks, everyone!