Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: unclosed v-row #730

Merged
merged 1 commit into from
Jul 15, 2021
Merged

BUG: unclosed v-row #730

merged 1 commit into from
Jul 15, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jul 15, 2021

I think there is a missing </v-row>.

@pllim pllim added bug Something isn't working Ready for final review labels Jul 15, 2021
rosteen
rosteen approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, weird - in my experience usually the plugin won't render at all if there's something like this in the vue file (although maybe I'm thinking more of typos in the element names). Anyway, good catch.

@rosteen rosteen merged commit 92ce20b into spacetelescope:main Jul 15, 2021
@rosteen
Copy link
Collaborator

rosteen commented Jul 15, 2021

This is trivial enough that I merged with one review.

@pllim pllim deleted the v-row-row-your-boat branch July 15, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosteen rosteen rosteen approved these changes

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

@ibusko ibusko Awaiting requested review from ibusko

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

Assignees
No one assigned
Labels
bug Something isn't working Ready for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @rosteen