Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Bump minversion of glue-core and glue-jupyter #805

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 25, 2021

Description

This pull request is to bump minversions of glue-core and glue-jupyter. They contains fixes required by Ori and also several outstanding PRs.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@pllim pllim requested a review from astrofrog August 25, 2021 14:05
@pllim pllim added trivial Only needs one approval instead of two 🔥 Critical Ready for final review labels Aug 25, 2021
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #805 (43b9acd) into main (aeb022a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   67.75%   67.75%           
=======================================
  Files          65       65           
  Lines        4459     4459           
=======================================
  Hits         3021     3021           
  Misses       1438     1438           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb022a...43b9acd. Read the comment docs.

@pllim pllim merged commit 9c0bdf9 into spacetelescope:main Aug 25, 2021
@pllim pllim deleted the bump-sticky-deps branch August 25, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Critical Ready for final review trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants