-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIRCam Background Monitor updates #1440
NIRCam Background Monitor updates #1440
Conversation
Hello @bsunnquist, Thank you for updating !
Comment last updated at 2024-02-02 18:43:12 UTC |
Could you add JBT to the environment files, requirements.txt, and (I think) setup.py? |
Added the JBT to the requirements - looks like the regression tests all ran OK. Most packages required by |
Thanks for this @bsunnquist looks like we have a conflict. Would you mind resolving it? Thank you! |
@mfixstsci merge conflict should be fixed now |
Thank you @bhilbert4 I will go ahead and review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bsunnquist this looks great. I am going to test it locally as well.
Just finished local testing, thank you @bsunnquist everything looks good to me 👍 |
Thanks @mfixstsci ! Did you get those 2 new database columns working on the server (doy and total_bkg)? If so, I'll prepare a request to insert some historical data into those updated databases in a separate issue. |
As of right now, I don't believe the columns are there but the web application and figure generation were successful. We are meeting today to discuss the database changes! |
This PR makes the following changes based on NIRCam team feedback:
pip install jwst_backgrounds
in jwql environment). This also requires two new columns in the NIRCamClawStats database (doy
andtotal_bkg
).