Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NIRSpec TA Monitors to use Django DB Models #1499

Merged
merged 21 commits into from
May 2, 2024
Merged

Update NIRSpec TA Monitors to use Django DB Models #1499

merged 21 commits into from
May 2, 2024

Conversation

mfixstsci
Copy link
Collaborator

No description provided.

@pep8speaks
Copy link

pep8speaks commented Feb 23, 2024 •
edited
Loading

Hello @mfixstsci, Thank you for updating !

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated at 2024-05-02 16:32:18 UTC

@mfixstsci mfixstsci changed the title WIP Update NIRSpec TA Monitors to use Django DB Models Update NIRSpec TA Monitors to use Django DB Models Mar 4, 2024
@mfixstsci
Copy link
Collaborator Author

@BradleySappington and @york-stsci I was able to verify using my generic user account that data was queried from the models and then stored when the monitor was completed 👍 ready for review at your convenience.

mfixstsci added 15 commits March 4, 2024 17:54
@mfixstsci
Merge branch 'develop' into nrs-ta-mon-use-django-db
6885d2a
@mfixstsci
Updating query to django models
cb89fdd
@mfixstsci
Merge remote-tracking branch 'upstream/develop' into nrs-ta-mon-use-d…
3f2240a 
…jango-db
@mfixstsci
Removed web scraping from WATA monitor.
42897ae
@mfixstsci
Adding model definitions for NIRSpec TA
3c4aa0e
@mfixstsci
Merge remote-tracking branch 'upstream/develop' into nrs-ta-mon-use-d…
2f38f82 
…jango-db
@mfixstsci
Updates to nirspec ta monitors
7ebd13b
@mfixstsci
Missed some fields in the definitions
2b9ee56
@mfixstsci
Removing txt file definition, need to be defined in django model module.
5769304
@mfixstsci
Adding models to ta.py
d9a3b41
@mfixstsci
Updating imports and adding max length where possible
896c5a0
@mfixstsci
Merge remote-tracking branch 'upstream/develop' into nrs-ta-mon-use-d…
e32e481 
…jango-db
@mfixstsci
Adding updates to WATA monitor. Monitor now uses django model stats d…
a0fe172 
…b table
@mfixstsci
WATA and MSATA monitors both use statistics databases. Also bokeh dep…
929e150 
…recation warning updates
@mfixstsci
pep8, adding migration
d0204c1
BradleySappington
BradleySappington reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar enough with the monitors, so I'll need to go through this code with you to give a worthwhile review

jwql/instrument_monitors/nirspec_monitors/ta_monitors/msata_monitor.py Show resolved Hide resolved
@mfixstsci mfixstsci mentioned this pull request May 2, 2024
Open
@mfixstsci
Copy link
Collaborator Author

af8f574 addresses #1171 @bhilbert4

@mfixstsci
Copy link
Collaborator Author

Myself, @BradleySappington, @bhilbert4 and @york-stsci all reviewed this pull request over a phone call last week, merging now.

AFTER MERGE TO DO:

  • Reset NIRSpecTaQueryHistory on test
  • Reset NIRSpecTaQueryHistory on ops

@mfixstsci mfixstsci merged commit 60beaeb into spacetelescope:develop May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradleySappington BradleySappington BradleySappington left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfixstsci @pep8speaks @BradleySappington