Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix release upload step condition to match workflow trigger #1593

Merged
merged 1 commit into from
May 28, 2024
Merged

fix release upload step condition to match workflow trigger #1593

merged 1 commit into from
May 28, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented May 28, 2024 •
edited
Loading

the event type in the if: condition (published) was not the same as the event type in the trigger (released). Thus, the workflow would never satisfy the condition 😅

@zacharyburnett zacharyburnett requested a review from mfixstsci May 28, 2024 13:38
mfixstsci
mfixstsci approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zacharyburnett

@mfixstsci mfixstsci merged commit 933977a into spacetelescope:develop May 28, 2024
6 checks passed
@zacharyburnett zacharyburnett deleted the fix/build_release_upload branch May 28, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfixstsci mfixstsci mfixstsci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @mfixstsci