Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2928: Updating tests with place holders for new files. #7738

Closed

Conversation

kmacdonald-stsci
Copy link
Contributor

Resolves JP-2928

This PR addresses some regression tests needed changing according to JP-2928.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60%. Comparing base (d1a60ee) to head (3ced88a).
Report is 860 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7738   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files         456      456           
  Lines       36950    36950           
=======================================
  Hits        28304    28304           
  Misses       8646     8646           
Flag Coverage Δ *Carryforward flag
nightly 77.43% <ø> (ø) Carriedforward from d1a60ee

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke
Copy link
Collaborator

@kmacdonald-stsci - do you remember what was going on with this old PR? It looks like you proposed a new data set to replace pre-flight data, but we never followed through with it. Was there a reason why not, or did we just not get around to it?

@melanieclarke melanieclarke removed the request for review from hbushouse October 1, 2024 16:40
@kmacdonald-stsci
Copy link
Contributor Author

@kmacdonald-stsci - do you remember what was going on with this old PR? It looks like you proposed a new data set to replace pre-flight data, but we never followed through with it. Was there a reason why not, or did we just not get around to it?

I believe this was part of the effort to change regression tests to using actual data instead of simulated data. I was asked to change some regression tests to update file names reflecting that, but I didn't have authority to update the data itself, so it never got approved or merged. I'm certain this can be closed.

@melanieclarke
Copy link
Collaborator

Okay, thanks, I will close this one and use the suggested file as a starting point for updating the nircam/tsgrism data later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants