Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3244: Provide auto-centering option for slit-like data containing point sources #7763

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tapastro
Copy link
Contributor

Resolves JP-3244

This PR addresses the inaccuracy inherent in using the user-provided TARG_RA/TARG_DEC as source location descriptors for defining the extraction region. The code submitted here collapses the 2D bounding box along the dispersion axis, fits a function to the resulting spatial extent (here a gaussian, but this could be changed), and uses the fit to determine the cross-dispersion extraction bounds.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@tapastro tapastro added this to the Build 10.0 milestone Jul 25, 2023
@tapastro tapastro requested a review from a team as a code owner July 25, 2023 19:30
@tapastro tapastro self-assigned this Jul 25, 2023
@tapastro tapastro marked this pull request as draft July 25, 2023 19:30
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 4.76% and project coverage change: -1.47% ⚠️

Comparison is base (d1a60ee) 76.60% compared to head (8c7f6c1) 75.13%.
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7763      +/-   ##
==========================================
- Coverage   76.60%   75.13%   -1.47%     
==========================================
  Files         456      456              
  Lines       36950    38277    +1327     
==========================================
+ Hits        28304    28758     +454     
- Misses       8646     9519     +873     
Flag Coverage Δ *Carryforward flag
nightly 77.43% <ø> (-0.01%) ⬇️ Carriedforward from 779e3e6

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
jwst/extract_1d/extract_1d_step.py 77.27% <ø> (ø)
jwst/extract_1d/extract.py 76.47% <4.76%> (-2.17%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nden nden removed this from the Build 10.0 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants