-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stitch plugin #107
Stitch plugin #107
Conversation
3a717f6
to
1f2a2cc
Compare
Some thoughts:
|
✅ 🪡
ok, then I'll add it (but not sure about having it on by default - we'll see as we play with it I guess)
I'm not sure I agree with this. All of the other plugins take a single light curve as input, so this allows you to combine multiple quarters/sectors together and then use that as input to... frequency analysis, binning, etc. Down the road, we may want to have that done on the fly by allowing any plugin to have multi-select support for the dataset and stitch on the fly, but again, without necessarily normalizing or flattening as part of that process.
Maybe, but definitely not for this first pass. And I think we want model fitting on its own... it just needs to be completely refactored to not rely on specutils.
Good idea - I support this. EDIT: done in #111 |
only shown in plugin tray if at least two light curves are loaded into a viewer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 93.92% 92.39% -1.54%
==========================================
Files 37 41 +4
Lines 1598 1933 +335
==========================================
+ Hits 1501 1786 +285
- Misses 97 147 +50 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great for me, and I like the delete feature – very easy.
* stitch plugin: basic implementation * only shown in plugin tray if at least two light curves are loaded into a viewer * optionally replace input datasets when stitching
Screen.Recording.2024-04-16.at.2.19.02.PM.mov
Stitch plugins docs
Potential follow-up:
corrector_func
.See https://docs.lightkurve.org/reference/api/lightkurve.LightCurveCollection.stitch.html
Open questions: