Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maker_utils so that saved nodes are still returned #218

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Jun 22, 2023

@stscieisenhamer requested that the maker_utils return the nodes even when they are saving the node to ASDF. This will not effect any current uses as the output will be thrown away, but it will enable one to use the node made by the maker_util and saved to a file without having to open that file.

Checklist

Copy link
Collaborator

@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: I never completed the jira issue filing. So, nevermind on that.

@WilliamJamieson WilliamJamieson force-pushed the feature/maker_utils_output_saved branch from 5afb10c to d0bcb08 Compare June 22, 2023 18:54
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.30 ⚠️

Comparison is base (c0a084d) 94.47% compared to head (3f5c1d0) 94.17%.

❗ Current head 3f5c1d0 differs from pull request most recent head 674c30c. Consider uploading reports for the commit 674c30c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   94.47%   94.17%   -0.30%     
==========================================
  Files          23       23              
  Lines        1628     1545      -83     
==========================================
- Hits         1538     1455      -83     
  Misses         90       90              
Impacted Files Coverage Δ
src/roman_datamodels/maker_utils/_base.py 100.00% <100.00%> (ø)
src/roman_datamodels/maker_utils/_datamodels.py 95.77% <100.00%> (-0.80%) ⬇️
src/roman_datamodels/maker_utils/_ref_files.py 95.62% <100.00%> (-1.29%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson WilliamJamieson force-pushed the feature/maker_utils_output_saved branch 10 times, most recently from f9bb814 to eae5708 Compare June 27, 2023 18:17
@WilliamJamieson WilliamJamieson force-pushed the feature/maker_utils_output_saved branch from eae5708 to 2a40e72 Compare July 4, 2023 02:06
@WilliamJamieson WilliamJamieson force-pushed the feature/maker_utils_output_saved branch from 2a40e72 to 2b597fa Compare July 6, 2023 13:34
@WilliamJamieson WilliamJamieson force-pushed the feature/maker_utils_output_saved branch from 3f5c1d0 to 674c30c Compare July 6, 2023 16:15
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sweep sweep sweep

@WilliamJamieson WilliamJamieson merged commit c19cde4 into spacetelescope:main Jul 7, 2023
13 checks passed
@WilliamJamieson WilliamJamieson deleted the feature/maker_utils_output_saved branch July 7, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants