Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maker_utils for new cal_step keys. #228

Merged

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Jun 28, 2023

This PR adds the additional step keys added spacetelescope/rad#282 to the maker_utils maker function for cal_step.

Checklist

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (46e722b) 94.73% compared to head (2d23c2f) 94.74%.

❗ Current head 2d23c2f differs from pull request most recent head 62a5c70. Consider uploading reports for the commit 62a5c70 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   94.73%   94.74%   +0.01%     
==========================================
  Files          23       23              
  Lines        1538     1542       +4     
==========================================
+ Hits         1457     1461       +4     
  Misses         81       81              
Impacted Files Coverage Δ
src/roman_datamodels/maker_utils/_common_meta.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson WilliamJamieson force-pushed the feature/update_cal_step branch 6 times, most recently from 2d23c2f to 2ac836c Compare July 8, 2023 00:20
@nden
Copy link
Collaborator

nden commented Jul 10, 2023

@WilliamJamieson Is this ready for review now that the rad PR was merged?
I think this is the only piece in the way of merging the reference pixel correction.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review July 10, 2023 14:35
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 10, 2023 14:35
@WilliamJamieson
Copy link
Contributor Author

@WilliamJamieson Is this ready for review now that the rad PR was merged? I think this is the only piece in the way of merging the reference pixel correction.

It is ready now.

@WilliamJamieson WilliamJamieson merged commit 36e98e3 into spacetelescope:main Jul 10, 2023
15 checks passed
@WilliamJamieson WilliamJamieson deleted the feature/update_cal_step branch July 10, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants