Clean up random numbers #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 23 23
Lines 1628 1628
=======================================
Hits 1538 1538
Misses 90 90
☔ View full report in Codecov by Sentry. |
WilliamJamieson
force-pushed
the
feature/remove_randomness
branch
from
299dacc
to
32b1395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar fashion (though with no bugs intermittent failures) to spacetelescope/romcal#771, this PR makes all of the "random" numbers generated in the tests deterministic and removes a random number generation overlooked in the
maker_utils.Checklist
CHANGES.rstunder the corresponding subsectionPassed romancal regression testing on Jenkins / PLWishMaster. Link: https://plwishmaster.stsci.edu:8081/job/RT/job/romancal/XXX/