test with python 3.13 #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 97.56% 97.75% +0.19%
==========================================
Files 30 36 +6
Lines 2788 3434 +646
==========================================
+ Hits 2720 3357 +637
- Misses 68 77 +9 ☔ View full report in Codecov by Sentry. |
WilliamJamieson
force-pushed
the
py313
branch
from
c87a730 to
ed6bf29
Compare
WilliamJamieson
approved these changes
Oct 18, 2024
|
This will need the branch protections updated so that the linux py311 requirement is replaced by the linux py311-cov job instead. @zacharyburnett or @braingram can either of you update the branch protections after merging this? |
|
Thanks! I updated the branch protection rules. Let me know if they look good to you or if you notice any other changes there that would be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds python 3.13 to the CI.
I also removed the
py311environment (testing with python 3.11) since we're already runningpy311-cov(python 3.11 while measuring coverage). This change will require updates to the branch protection rules as currentlypy311is marked as required. I'm happy to remove that change from this PR (if that's preferred) just let me know.Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)romancalregression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change