-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin numpy <2 #1275
pin numpy <2 #1275
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1275 +/- ##
=======================================
Coverage 79.24% 79.24%
=======================================
Files 117 117
Lines 8075 8075
=======================================
Hits 6399 6399
Misses 1676 1676
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -10,6 +10,8 @@ Documentation | |||
general | |||
------- | |||
|
|||
- pin numpy to <2 [#1275] | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't generally add dependency versions to the changes file.
Numpy 2.0 was released. This is causing many tests to fail due to incompatible depedencies:
https://github.com/spacetelescope/romancal/actions/runs/9539663192/job/26290288431
These include:
This PR pins numpy to <2.
Checklist
CHANGES.rst
under the corresponding subsection