add CI check that CHANGES.rst is not modified

[braingram]

Add a CI check to make sure PRs don't change CHANGES.rst. Changelog entries now take the form of towncrier fragments and manual edits to CHANGES.rst are no longer needed.

Here's a run of the new check that fails (due to an edit to CHANGES.rst added temporarily to this PR): https://github.com/spacetelescope/romancal/actions/runs/10906504272/job/30267904518?pr=1412

Checklist

• for a public change, added a towncrier news fragment in changes/

  echo "changed something" > changes/<PR#>.<changetype>.rst

  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

  steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

• updated relevant tests

• updated relevant documentation

• updated relevant milestone(s)

• added relevant label(s)

• ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

[braingram]

Thanks! It doesn't look like I have permissions to update the branch protections but I think it makes sense to make changelog / no_changelog_edit required.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (cef755e) to head (0746f70).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files         117      117           
  Lines        7833     7833           
=======================================
  Hits         6151     6151           
  Misses       1682     1682           

Flag	Coverage Δ		*Carryforward flag
nightly	62.24% <ø> (ø)		Carriedforward from cef755e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[schlafly]

Is there a way to extend the message name / user readable portion so that we say something like "use towncrier" or something? If it's not easy, then forget it.

[braingram]

Thanks @schlafly how's changelog / uses_towncrier?

[schlafly]

That sounds good to me. Maybe changelog_uses_towncrier so it's clear that the changelog is the problem, and that using towncrier is the answer? Anyway, I'll defer to you, looks good, thanks.