Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove custom dms requirement logging in ramp fit regtests #1433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 2, 2024

With the new json file to manage the mapping between dms requirements and tests the custom logging produced by the ramp fit regtests is no longer needed. The listed requirements are already in the json file:

"DMS362": [
"romancal.regtest.test_ramp_fitting.test_rampfit_step"
],
"DMS363": [
"romancal.regtest.test_ramp_fitting.test_rampfit_step"
],
"DMS365": [
"romancal.regtest.test_wfi_pipeline.test_level2_grism_processing_pipeline"
],
"DMS366": [
"romancal.regtest.test_ramp_fitting.test_rampfit_step"
],
"DMS367": [
"romancal.regtest.test_ramp_fitting.test_rampfit_step"
],

This PR removes romancal.lib.dms and it's use in romancal/regtest/test_ramp_fitting.py.

Regtests all passed: https://github.com/spacetelescope/RegressionTests/actions/runs/11151098848

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.patch_match.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (8601da8) to head (31022ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
+ Coverage   78.38%   78.42%   +0.03%     
==========================================
  Files         118      117       -1     
  Lines        7680     7674       -6     
==========================================
- Hits         6020     6018       -2     
+ Misses       1660     1656       -4     
Flag Coverage Δ *Carryforward flag
nightly 62.12% <ø> (ø) Carriedforward from 8601da8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review October 2, 2024 21:26
@braingram braingram requested a review from a team as a code owner October 2, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant