Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3669: Updating the C Extension to do CHARGELOSS Read Noise Recalculations #275

Merged
merged 36 commits into from
Sep 10, 2024

Merge branch 'main' into jp_3669

d85f859
Select commit
Loading
Failed to load commit list.
Merged

JP-3669: Updating the C Extension to do CHARGELOSS Read Noise Recalculations #275

Merge branch 'main' into jp_3669
d85f859
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 1s

84.63% (+0.25%) compared to 3b0f596

View this Pull Request on Codecov

84.63% (+0.25%) compared to 3b0f596

Details

Codecov Report

Attention: Patch coverage is 72.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (3b0f596) to head (d85f859).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/ramp_fitting/ramp_fit.py 10.00% 9 Missing ⚠️
src/stcal/ramp_fitting/ramp_fit_class.py 47.05% 9 Missing ⚠️
src/stcal/ramp_fitting/ols_fit.py 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   84.38%   84.63%   +0.25%     
==========================================
  Files          41       41              
  Lines        7557     7628      +71     
==========================================
+ Hits         6377     6456      +79     
+ Misses       1180     1172       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov