-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3110 Move dqflags
and related from stcal
to stdatamodels
#134
JP-3110 Move dqflags
and related from stcal
to stdatamodels
#134
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
===========================================
+ Coverage 0 50.10% +50.10%
===========================================
Files 0 127 +127
Lines 0 7814 +7814
===========================================
+ Hits 0 3915 +3915
- Misses 0 3899 +3899
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This fixes #133 |
3405f06
to
ed785ed
Compare
ed785ed
to
326c543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. Just one question.
60d344f
to
d0c3888
Compare
Resolves JP-3110
This PR moves:
stcal.dqflags
stcal.dynamicdq
stcal.basic_utils
To
stdatamodels
. These modules appear to only be used byjwst
.This is to facilitate making
stdatamodels
independent of the JWST pipeline code, so that users ofjwst
pipeline products can open those products using tools likejdaviz
without having to install the entire JWST pipeline. Instead,stdatamodels
contains all the necessary code to unpack the asdf-in-fits objects embedded in some jwst pipeline products.Fixes #133
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)