Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3110 Move dqflags and related from stcal to stdatamodels #134

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Mar 1, 2023

Resolves JP-3110

This PR moves:

  • stcal.dqflags
  • stcal.dynamicdq
  • stcal.basic_utils

To stdatamodels. These modules appear to only be used by jwst.

This is to facilitate making stdatamodels independent of the JWST pipeline code, so that users of jwst pipeline products can open those products using tools like jdaviz without having to install the entire JWST pipeline. Instead, stdatamodels contains all the necessary code to unpack the asdf-in-fits objects embedded in some jwst pipeline products.

Fixes #133

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 37.50% and project coverage change: +50.10 🎉

Comparison is base (314180a) 0.00% compared to head (60d344f) 50.10%.

❗ Current head 60d344f differs from pull request most recent head d0c3888. Consider uploading reports for the commit d0c3888 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #134       +/-   ##
===========================================
+ Coverage        0   50.10%   +50.10%     
===========================================
  Files           0      127      +127     
  Lines           0     7814     +7814     
===========================================
+ Hits            0     3915     +3915     
- Misses          0     3899     +3899     
Flag Coverage Δ
unit 50.10% <37.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stdatamodels/basic_utils.py 0.00% <0.00%> (ø)
src/stdatamodels/dqflags.py 0.00% <0.00%> (ø)
src/stdatamodels/dynamicdq.py 0.00% <0.00%> (ø)
src/stdatamodels/jwst/datamodels/dark.py 63.63% <100.00%> (ø)
src/stdatamodels/jwst/datamodels/darkMIRI.py 63.63% <100.00%> (ø)
src/stdatamodels/jwst/datamodels/dqflags.py 100.00% <100.00%> (ø)
src/stdatamodels/jwst/datamodels/flat.py 70.00% <100.00%> (ø)
src/stdatamodels/jwst/datamodels/fringe.py 63.63% <100.00%> (ø)
src/stdatamodels/jwst/datamodels/lastframe.py 63.63% <100.00%> (ø)
src/stdatamodels/jwst/datamodels/linearity.py 66.66% <100.00%> (ø)
... and 134 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor

pllim commented Mar 1, 2023

This fixes #133

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Just one question.

tox.ini Outdated Show resolved Hide resolved
@WilliamJamieson WilliamJamieson force-pushed the refactor/move_stcal_dqflags branch from 60d344f to d0c3888 Compare March 7, 2023 21:10
@WilliamJamieson WilliamJamieson merged commit 807f035 into spacetelescope:master Mar 7, 2023
@WilliamJamieson WilliamJamieson deleted the refactor/move_stcal_dqflags branch March 7, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove stcal as dependency
4 participants