remove unused V23ToSkyConverter from jwst.transforms extension 1.0.0 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V23ToSkyConverter is supported in the jwst.transforms asdf extension version 0.7.0 (see 0.7.0 manifest) but is not currently supported in 1.0.0 (see 1.0.0 manifest) This removes V23ToSkyConverter from the 1.0.0 extension. Previously asdf ignored any Converter that lists tags that are not in the manifest. Newer versions of asdf will produce errors for Converters that don't support any supported tags (one's listed in the manifest) and implement a select_tag method (which this one does by inheriting from Converter).
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
- Coverage 64.06% 64.04% -0.02%
==========================================
Files 101 101
Lines 5565 5563 -2
==========================================
- Hits 3565 3563 -2
Misses 2000 2000
☔ View full report in Codecov by Sentry. |
|
Regression tests run: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/788/ all passed |
7 tasks
nden
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
The 0.7 converters are probably not used any more in any data files.
We can probably run a search on crds files and see if there are any left that use 0.7 versions.
Other than that the archive should only have files using 1.0.
Something to discuss with Howard.
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V23ToSkyConverter is supported in the jwst.transforms asdf extension version 0.7.0 (see 0.7.0 manifest) but is not currently supported in 1.0.0 (see 1.0.0 manifest)
This removes V23ToSkyConverter from the 1.0.0 extension (which already does not support the tag) and in all prior versions of asdf this converter was ignored.
Previously asdf ignored any Converter that lists tags that are not in the manifest. This behavior is undocumented and may conflict with future asdf changes. asdf is changing Converter.select_tag to allow Converter deferral (see asdf-format/asdf#1561) where a converter can support no tags but still support types (where the converter will convert the object being serialized to a new type which is handled by a different converter).
Checklist
CHANGES.rst(either inBug FixesorChanges to API)