Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting started guide #122

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

joseph-long
Copy link
Contributor

I helped walk a student through this process today. There were points where a tempting copy-and-paste-able command did not apply to their system (i.e. it was for macOS and not Linux, and it didn't point to the latest version). I think any command that looks like it can be copied and pasted unmodified eventually will be, so I changed the steps to be the "shortcut" path of just giving a URL to conda and letting it go. The Readthedocs theme also cuts off the end of the commands and it's not always obvious the box will scroll, so the student was missing that --name was an important option to include.

Happy to iterate on this if you're not happy with it as written or explain my changes further if you want. Just trying to smooth over some bumps in the road I noticed with them earlier today.

Maybe some day there will be a redirect URL so you can just say conda env create -n stenv --file https://stsci.edu/stenv/mac or something 😃

Make it impossible to blindly copy and paste the wrong download command for your OS
Simplify the instructions for the case where you install directly from a URL
Explain the purpose of the different options available under "assets"
@joseph-long joseph-long requested a review from a team as a code owner November 15, 2023 01:57
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 15, 2023
Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, these changes are much better communication than what I had! I just had a few additional suggestions to further emphasize that the user can choose the environment name.

docs/source/getting_started.rst Outdated Show resolved Hide resolved
docs/source/getting_started.rst Outdated Show resolved Hide resolved
docs/source/getting_started.rst Outdated Show resolved Hide resolved
Co-authored-by: Zach Burnett <zachary.r.burnett@gmail.com>
@joseph-long
Copy link
Contributor Author

Great, thanks for your suggestions! I have accepted all of them so this should be ready to merge.

@zacharyburnett zacharyburnett merged commit 7c7100f into spacetelescope:main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants