Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for step.save and step.skip #197

Merged
merged 16 commits into from
Jan 27, 2025

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Oct 10, 2024

This PR adds the unit tests from #190 as it looks like that PR is likely to be withdrawn, at least for the time being, but the unit tests are still relevant to the main branch.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stpipe@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@emolter emolter requested a review from a team as a code owner October 10, 2024 19:58
@emolter emolter added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 95.76271% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.37%. Comparing base (1acb486) to head (1021d15).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_step.py 95.76% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   95.27%   95.37%   +0.09%     
==========================================
  Files          37       37              
  Lines        3177     3244      +67     
==========================================
+ Hits         3027     3094      +67     
  Misses        150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter mentioned this pull request Oct 10, 2024
7 tasks
tests/test_step.py Outdated Show resolved Hide resolved
tests/test_step.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. I left a few comments/suggestions.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emolter emolter merged commit 53ca364 into spacetelescope:main Jan 27, 2025
16 of 18 checks passed
@emolter emolter deleted the step-save-tests branch January 27, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed does not require an entry in `CHANGES.rst`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants