Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build configuration into pyproject.toml #56

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jun 2, 2022

setuptools now supports the [project] table, which is defined by PEP621.

Additionally, setuptools now supports its own entry in pyproject.toml called [tool.setuptools] (pypa/setuptools#1688, https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration); however, it comes with the following disclaimer:

Support for declaring configurations not standardized by PEP 621 (i.e. the [tool.setuptools] table), is still in beta stage and might change in future releases.

Given this, we can attempt to consolidate the build configuration into a single pyproject.toml file that can possibly be read by other build systems in the future.

@zacharyburnett zacharyburnett self-assigned this Jun 2, 2022
@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch from 317da7a to e81eeaa Compare June 2, 2022 19:18
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (4576e39) compared to base (1c14205).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #56   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          25      25           
  Lines        3060    3060           
======================================
  Misses       3060    3060           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett
Copy link
Collaborator Author

I was able to get the tests to run through correctly by removing usage of tox, similar to in spacetelescope/stcal#96

@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch from 39cddf2 to 7d8d689 Compare June 7, 2022 13:13
@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch from b5955d1 to 2680274 Compare June 17, 2022 14:16
@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch from 2680274 to 976b799 Compare July 5, 2022 19:58
@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch from 976b799 to fa28697 Compare July 29, 2022 13:37
@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch from fa28697 to bb5311e Compare August 17, 2022 15:14
@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch 3 times, most recently from 4b14a80 to 17b7c41 Compare September 20, 2022 14:03
@zacharyburnett
Copy link
Collaborator Author

@WilliamJamieson I didn't realize that stpipe doesn't have a RTD site, I can make a PR to add that so we can get rid of the docs job in github actions

pyproject.toml Outdated Show resolved Hide resolved
@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch from bae487e to 6fca1e4 Compare October 24, 2022 19:47
@zacharyburnett zacharyburnett marked this pull request as ready for review November 30, 2022 14:16
@zacharyburnett zacharyburnett force-pushed the consolidate_build_config branch from 6fca1e4 to 4576e39 Compare December 15, 2022 13:40
@zacharyburnett zacharyburnett merged commit 6d997ba into spacetelescope:master Dec 15, 2022
@zacharyburnett zacharyburnett deleted the consolidate_build_config branch December 15, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants