Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scripts metadata to include strun as a standalone Python script in package #76

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Dec 16, 2022

by adding the scripts parameter to setup(), strun is included in the PATH when the package is installed

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (56715c1) compared to base (e29d9d3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #76   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          25      25           
  Lines        3060    3060           
======================================
  Misses       3060    3060           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett marked this pull request as ready for review December 16, 2022 14:18
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, but then I don't really understand how it all works (that's why we have system/installation engineers).

@zacharyburnett zacharyburnett merged commit 0f6f03d into spacetelescope:master Dec 16, 2022
@zacharyburnett zacharyburnett deleted the include_scripts branch December 16, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants