-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert FromCommandLine to str before building Step #78
Conversation
When string arguments are passed in via the command line they are converted to FromCommandLine instances. Convert them back to strings before providing them as keyword arguments while building the step.
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 25 25
Lines 3060 3066 +6
======================================
- Misses 3060 3066 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Regtest run using this PR branch shows no errors for the niriss_soss tests that previously crashed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it's the right change to make, but it seems to work!
This looks reasonable to me. I think the problem started when list arguments were enabled again in #73. |
I tested manually running a step with list parameters and confirmed this works. Writing a formal test can be done later. |
When string arguments are passed in via the command line they are converted to FromCommandLine instances. Convert them back to strings before providing them as keyword arguments while building the step.
It appears this conversion is only needed to resolve the path of input and output files provided to the step
stpipe/src/stpipe/config_parser.py
Lines 38 to 46 in 454314b
This will hopefully fix the failing regression tests for spacetelescope/jwst#7403 and other instances of similar failures.