Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LCViz tutorial notebook #46

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Oct 30, 2024

Basic example of using LCViz with data retrieval from S3. Apparently the data retrieval, which works locally for me, doesn't actually work on TIKE, so this will need a little debugging.

@ttdu ttdu self-assigned this Oct 30, 2024
@ttdu
Copy link
Collaborator

ttdu commented Nov 4, 2024

after running .flatten in the code cell, the plot looks strange:
flatten

bizarrely, if I open the "flatten" option in the side menu, the points re-appear:
working-flatten

@kecnry
Copy link
Member

kecnry commented Nov 4, 2024

This is a known bug that we are trying to get fixed upstream in bqplot. If we can't get that in in time, perhaps we should disable normalization in the notebook?

@rosteen
Copy link
Contributor Author

rosteen commented Nov 4, 2024

As Kyle said, this is an upstream bug that I'm hoping gets resolved in the next week or two (i.e., before this notebook would be merged). I should have mentioned it when I opened this PR - if for some reason it's not fixed by the end of November I'll remove that section.

@rosteen
Copy link
Contributor Author

rosteen commented Dec 2, 2024

I added a note about the display bug and an edit to avoid it (by not normalizing the flattened curve), as well as one fix that I think was needed due to the new Astropy release.

@kecnry
Copy link
Member

kecnry commented Dec 2, 2024

lcviz 1.0 is now released and available from pip

@ttdu
Copy link
Collaborator

ttdu commented Dec 11, 2024

last thing and then I'll merge: we use a literature reference for the period, we should link to it in the notebook. It's not clear to me which of the three papers on HAT-P-11 authored by Brett in 2017 is the correct one

@kecnry
Copy link
Member

kecnry commented Dec 11, 2024

@bmorris3 - any preference?

@bmorris3
Copy link

haha @ttdu, I still won't shut up about that star. It's this one: https://ui.adsabs.harvard.edu/abs/2017ApJ...846...99M/abstract

@rosteen
Copy link
Contributor Author

rosteen commented Dec 30, 2024

FYI the upstream bug with displaying the flattened light curve was fixed, so I removed the workaround.

@ttdu ttdu merged commit 32bffcb into spacetelescope:main Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants