Conversation
|
The regex-based branch automated build isn't working, and I'm wondering if it could be related to this issue. |
Although who knows, is it possible Docker Hub is waiting for this recently triggered gitlab check to finish? For some reason pushing the same sha to a different branch name (one that should match the autobuild rule) also re-triggered the gitlab pipeline, even though that new branch name is not associated with this PR. |
becker33
left a comment
There was a problem hiding this comment.
A couple corrections on the compilers.
| g++-4.8 \ | ||
| gcc \ | ||
| gcc-4.8 \ | ||
| gfortran \ | ||
| gfortran-4.8 \ |
There was a problem hiding this comment.
I think we need a gcc-6.5 in here. We need to have multiple system gccs.
There was a problem hiding this comment.
Ok, I'll add 6.5.0
docker/tutorial-test.sh
Outdated
| spack install zlib %clang | ||
| spack install zlib @1.2.8 | ||
| spack install zlib %gcc@4.8 | ||
| spack install zlib %gcc@7.5.0 |
There was a problem hiding this comment.
I think this should be gcc@6.5.0. There's no gcc@7.5.0 on the system when the users log in, and this isn't a compiler that we bootstrap during the tutorial.
There was a problem hiding this comment.
I picked gcc@7.5.0, because that's what is installed when the Dockerfile installs gcc, g++ and gfortran. But if I'm going to specifically install 6.5.0 too, then I can change the 4.8 in the test script to 6.5.0...
There was a problem hiding this comment.
Yeah the whole point of this one is it's demonstrating changing the compiler version, so it needs to be different from the spec of the default gcc.
docker/tutorial-test.sh
Outdated
| spack install tcl | ||
| spack install tcl ^zlib @1.2.8 %clang | ||
| spack install tcl ^/64mn | ||
| spack install tcl ^/64mn |
There was a problem hiding this comment.
In the most recent version of the tutorial this was /hmvj. It needs to be the hash of the zlib@1.2.8 cppflags=-O3 spec.
There was a problem hiding this comment.
Ok, thanks for the heads up, I'll see what the hash is now and set it to that.
|
@becker33 IIRC the |
|
Yes, there should be a |
|
We target the whole thing for x86_64 because we can't know what machine they'll run the container on. When the new aarch64 macs become popular we may have to create two versions of the container. |
4bcc073 to
fae46e0
Compare
|
I wish I'd seen this earlier. Just got someone set up to run the tutorial and ran into a few roadblocks. Summarized it to the mailing list, but adding it here for posterity: Their docker image is missing the Here's a functional Dockerfile: Start the new container like so: After you start the container and work through the tutorial, you'll
|
No description provided.