update mfem to handle hypre 2.29.0 +rocm #2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
alecbcs
requested changes
Nov 26, 2025
Member
alecbcs
left a comment
alecbcs
left a comment
There was a problem hiding this comment.
One quick nitpick. Otherwise this looks pretty good to me. Thanks @chapman39!
Co-authored-by: Alec Scott <hi@alecbcs.com>
alecbcs
approved these changes
Dec 2, 2025
Member
alecbcs
left a comment
alecbcs
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @chapman39!
mkrack
pushed a commit
to mkrack/spack-packages
that referenced
this pull request
Dec 23, 2025
* update mfem to handle hypre 2.29.0 +rocm * Update repos/spack_repo/builtin/packages/mfem/package.py Co-authored-by: Alec Scott <hi@alecbcs.com> --------- Co-authored-by: Alec Scott <hi@alecbcs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hypre version 2.29+rocm and beyond have additional dependencies that need to be linked.
https://github.com/spack/spack-packages/blob/develop/repos/spack_repo/builtin/packages/hypre/package.py#L215-L216