Skip to content

Axom: Update ROCm root var #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chapman39 wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Axom: Update ROCm root var #2858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
da973e4
Axom: Update ROCm root var
chapman39 Dec 19, 2025
d4b5ff8
Merge branch 'develop' into bugfix/chapman39/axom-update-rocm-path
chapman39 Dec 30, 2025
05639b4
Merge branch 'develop' into bugfix/chapman39/axom-update-rocm-path
chapman39 Dec 30, 2025
9cf148c
fix wrong version
chapman39 Jan 2, 2026
c4c1ee8
Merge branch 'bugfix/chapman39/axom-update-rocm-path' of github.com:c…
chapman39 Jan 2, 2026
93a6199
Apply suggestions from code review
chapman39 Jan 5, 2026
d87b2b8
Apply suggestions from code review
chapman39 Jan 5, 2026
2086492
Merge branch 'develop' into bugfix/chapman39/axom-update-rocm-path
chapman39 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion repos/spack_repo/builtin/packages/axom/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def initconfig_hardware_entries(self):

hip_link_flags = ""

rocm_root = spec["llvm-amdgpu"].prefix
rocm_root = os.path.dirname(spec["llvm-amdgpu"].prefix)
entries.append(cmake_cache_path("ROCM_ROOT_DIR", rocm_root))

# Recommended MPI flags
Expand Down
2 changes: 1 addition & 1 deletion repos/spack_repo/builtin/packages/mfem/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ def find_optional_library(name, prefix):
hypre_rocm_libs += hypre["rocsparse"].libs
if "^rocrand" in hypre:
hypre_rocm_libs += hypre["rocrand"].libs
if hypre.satisfies("@2.39.0:"):
if hypre.satisfies("@2.29.0:"):
if "^rocsolver" in hypre:
hypre_rocm_libs += hypre["rocsolver"].libs
if "^rocblas" in hypre:
Expand Down
Loading