-
Notifications
You must be signed in to change notification settings - Fork 40
Various fixes #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #485
Conversation
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
9b7fcc9
to
bd8db28
Compare
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR applies various fixes to ensure the documentation is in sync with the main Spack repository and resolves formatting, style, and configuration issues.
- Fixes Google Analytics token to use tutorial-specific tracking instead of conflating with spack.readthedocs.io
- Updates conf.py configuration to match spack/spack and adds custom HTML formatter
- Applies consistent RST formatting throughout documentation files
Reviewed Changes
Copilot reviewed 19 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
_templates/base.html | Updates Google Analytics tracking ID from shared to tutorial-specific |
conf.py | Synchronizes configuration with spack/spack, adds custom HTML formatter, and updates extensions |
.readthedocs.yaml | Enables fail_on_warning and adds post_checkout job for accurate timestamps |
.gitmodules | Adds _spack_packages submodule reference |
_spack_packages | Adds submodule commit reference |
.github/workflows/style.yml | Updates style check workflow to install dependencies and use proper file selection |
tutorial_*.rst files | Applies consistent RST formatting by breaking long lines and fixing indentation |
common/setup.rst | Applies line formatting fixes |
index.rst | Applies line formatting fixes |
Comments suppressed due to low confidence (1)
conf.py:1
- The path appears to have an extra '/base' directory. Should be
_spack_root/etc/spack/defaults/packages.yaml
based on standard Spack directory structure.
# Copyright Spack Project Developers. See COPYRIGHT file for details.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ca70e19
to
c627c76
Compare
c627c76
to
c15e79c
Compare
Uh oh!
There was an error while loading. Please reload this page.